Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hints for openlibrary/utils/sentry.py #6329

Merged
merged 1 commit into from
Mar 24, 2022
Merged

Type hints for openlibrary/utils/sentry.py #6329

merged 1 commit into from
Mar 24, 2022

Conversation

cclauss
Copy link
Collaborator

@cclauss cclauss commented Mar 24, 2022

Convert Python type comments into type hints.

Technical

Testing

Screenshot

Stakeholders

@cclauss cclauss added Module: Python python Pull requests that update Python code labels Mar 24, 2022
@cclauss cclauss requested a review from cdrini March 24, 2022 17:49
@cclauss cclauss mentioned this pull request Mar 24, 2022
Merged
cdrini
cdrini approved these changes Mar 24, 2022
View reviewed changes
Copy link
Collaborator

@cdrini cdrini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm; mypy passes!

@cdrini cdrini merged commit 3d43210 into internetarchive:master Mar 24, 2022
@cdrini cdrini self-assigned this Mar 24, 2022
@cclauss cclauss deleted the type-hints-for-sentry branch March 24, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdrini cdrini cdrini approved these changes

Assignees

@cdrini cdrini

Labels
python Pull requests that update Python code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cclauss @cdrini @mekarpeles